Support native console in linux aarch64 for JRuby #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am running JRuby on a Linux aarch64. I can see the `io/console/ffi/stty_console` is being loaded based on the warning message: "io/console on JRuby shells out to stty for most operations" If I manually require `io/console/ffi/native_console` it fails due to the platform guard at the top of the file. However, if I remove that guard it, it loads and works fine in my brief testing. In ruby#40, @headius confirmed there is no reason not to allow aarch64, so adding it in this PR. Closes ruby#40.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am running JRuby on a Linux aarch64.
I can see the
io/console/ffi/stty_consoleis being loaded based on the warning message:"io/console on JRuby shells out to stty for most operations"
If I manually require
io/console/ffi/native_consoleit fails due to the platform guard at the top of the file.However, if I remove that guard it, it loads and works fine in my brief testing.
In #40, @headius confirmed there is no reason not to allow aarch64, so adding it in this PR. Closes #40.